lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] usb_debug: implement multi urb write
On Tue, May 05, 2009 at 09:00:01PM -0500, Jason Wessel wrote:
> The usb_debug driver, when used as the console, will always fail to
> insert the carriage return and new line sequence as well as randomly
> drop console output. This is a result of only having the single
> write_urb and that the tty layer will have a lock that prevents the
> processing of the back to back urb requests.
>
> The solution is to allow more than one urb to be outstanding and have
> a slightly deeper transmit queue. The idea and some code is borrowed
> from the ftdi_sio usb driver.

Almost all usb-serial drivers need this functionality.

As you are adding it to the usb_debug driver, why not just add this kind
of functionality to the usb-serial core instead, that way we can share
it with all of the drivers? I'd much rather see that happen instead of
us doing it individually again.

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-05-06 17:37    [W:0.061 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site