lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] x86: introduce cpuinfo->cpu_node_id to reflect topology of multi-node CPU

* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> ---
> arch/x86/include/asm/processor.h | 2 ++
> arch/x86/kernel/cpu/common.c | 2 ++
> arch/x86/kernel/cpu/proc.c | 1 +
> arch/x86/kernel/smpboot.c | 5 ++++-
> 4 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
> index 0b2fab0..b49d72b 100644
> --- a/arch/x86/include/asm/processor.h
> +++ b/arch/x86/include/asm/processor.h
> @@ -106,6 +106,8 @@ struct cpuinfo_x86 {
> u16 booted_cores;
> /* Physical processor id: */
> u16 phys_proc_id;
> + /* Node id in case of multi-node processor: */
> + u16 cpu_node_id;

btw., do you have any plans to propagate this information into the
scheduler domains tree?

Another level of domains, to cover the two internal nodes, would do
the trick nicely and automatically. This would work even if the BIOS
does not provide information and we have to go to lowlevel registers
or CPUID to recover it.

This can be done even if there's no SRAT. (there's no SRAT because
say due to interleaving there's no real NUMA structure of memory.
But there's still CPU scheduling differences worth expressing.)

Ingo


\
 
 \ /
  Last update: 2009-05-06 13:49    [W:0.118 / U:32.312 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site