[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/3] NOMMU: Make the initial mmap allocation excess behaviour Kconfig configurable
Andrew Morton <> wrote:

> Nasty problem.

Yes. That's part of the fun of the NOMMU world. It has many of the same
problems as the MMU world - just more exaggerated.

> > -int sysctl_nr_trim_pages = 1; /* page trimming behaviour */
> > +int sysctl_nr_trim_pages = CONFIG_NOMMU_INITIAL_TRIM_EXCESS;
> > int heap_stack_gap = 0;
> >
> But there's a risk of -ENOMEM regression on other system here?

There shouldn't be (assuming you mean with this patch), the default is the
same as the original value.

> It's unlikely to be a huge problem for real-world embedded developers,
> as long as they know about this change. And because you set the
> Kconfig default to "no change" then I guess they'll be none the wiser.
> I think that patches 2 and 3 (and #1 unless I reorder and redo things)
> are 2.6.30 material. Agree?

Assuming you mean go in before 2.6.30 is cut, then yes. If you want, I can
reorder the patches to put #1 last.


 \ /
  Last update: 2009-05-06 13:49    [W:0.120 / U:1.896 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site