Messages in this thread | | | Date | Wed, 6 May 2009 13:02:58 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH, RFC] sputrace: use the generic event tracer |
| |
On Wed, May 06, 2009 at 12:57:48PM +0200, Ingo Molnar wrote: > Nice! Needs also an Ack from PowerPC folks before we can do this. > The cross section to other powerpc code seems to be rather low.
cbe-oss-dev is the Cell list.
> > -config SPU_TRACE > > - tristate "SPU event tracing support" > > - depends on SPU_FS && MARKERS > > - help > > - This option allows reading a trace of spu-related events through > > - the sputrace file in procfs. > > I think we should keep this option around.
Why? trace_events that aren't enabled are extremly low overhead. And most in the current tree are non-optional.
> > +# magic for the trace events > > +CFLAGS_sched.o := -I$(src) > > Steve, i'm wondering whether this type of Makefile hackery (caused > by modular tracepoints) could be eliminated ...
We would just have to include the header file with "" instead of <>. But I remember Steve not liking this when we talked about it.
| |