lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] sched: emit thread info flags with stack trace

* David Rientjes <rientjes@google.com> wrote:

> When a thread is oom killed and fails to exit, it's helpful to know which
> threads have access to memory reserves if the machine livelocks. This is
> done by testing for the TIF_MEMDIE thread info flag and should be
> displayed alongside stack traces to identify tasks that have access to
> such reserves but are still stuck allocating pages, for instance.
>
> It would probably be helpful in other cases as well, so all thread info
> flags are emitted when showing a task.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> kernel/sched.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -6490,8 +6490,9 @@ void sched_show_task(struct task_struct *p)
> #ifdef CONFIG_DEBUG_STACK_USAGE
> free = stack_not_used(p);
> #endif
> - printk(KERN_CONT "%5lu %5d %6d\n", free,
> - task_pid_nr(p), task_pid_nr(p->real_parent));
> + printk(KERN_CONT "%5lu %5d %6d 0x%08x\n", free,
> + task_pid_nr(p), task_pid_nr(p->real_parent),
> + task_thread_info(p)->flags);
>
> show_stack(p, NULL);
> }

ok. We just seem to have enough space to do that with
printk-timestamps enabled, without wrapping the line:

Before:

[62034.343909] as R running task 6240 27598 27596

After:

[62034.343909] as R running task 6240 27598 27596 0x12345678

Applied to tip/sched/core, thanks David!

Ingo


\
 
 \ /
  Last update: 2009-05-06 12:15    [W:0.044 / U:3.436 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site