Messages in this thread | | | Date | Wed, 6 May 2009 11:53:43 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] blktrace: correct remap names |
| |
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> > Subject: [PATCH] blktrace: correct remap names > > > > This attempts to clarify names utilized during block I/O remap operations > > (partition, volume manager). It correctly matches up the /from/ information for both device & sector. This takes in the concept from osaki Motohiro and extends it to include better naming for the "device_from" field. > > > > I also noticed this.. > > > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Cc: Li Zefan <lizf@cn.fujitsu.com> > > Cc: Jens Axboe <jens.axboe@oracle.com> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > > Signed-off-by: Alan D. Brunelle <alan.brunelle@hp.com> > > --- > > include/linux/blktrace_api.h | 4 ++-- > > include/trace/block.h | 4 ++-- > > kernel/trace/blktrace.c | 21 +++++++++++---------- > > 3 files changed, 15 insertions(+), 14 deletions(-) > > > > diff --git a/include/linux/blktrace_api.h b/include/linux/blktrace_api.h > > index d960889..da1a14e 100644 > > --- a/include/linux/blktrace_api.h > > +++ b/include/linux/blktrace_api.h > > @@ -116,9 +116,9 @@ struct blk_io_trace { > > * The remap event > > */ > > struct blk_io_trace_remap { > > - __be32 device; > > __be32 device_from; > > - __be64 sector; > > + __be32 device_to; > > + __be64 sector_from; > > }; > > > > If we are really fine with this change, then: > > Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
is it acceptable to break the sector output ordering of all past blktrace+blkparse binaries, as far as remap events go?
Ingo
| |