lkml.org 
[lkml]   [2009]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs
    From
    2009/5/5 Kevin Hilman <khilman@deeprootsystems.com>:
    > Arve Hjønnevåg <arve@android.com> writes:
    >
    >> On Tue, May 5, 2009 at 8:52 AM, Kevin Hilman
    > [...]
    >
    >> By leaving the interrupt enabled you prevent check_wakeup_irqs from
    >> aborting suspend.
    >
    > Yes, but it doesn't prevent platform-specific code from aborting
    > suspend.  On OMAP, the platform-specific suspend enter hook does a
    > last check for pending enabled interrupts very late in the sequence.
    > It seems to me that the platform specific code is the best place to do
    > this.

    It will not be pending anymore if the interrupt triggered before all
    interrupts were masked at the cpu.

    > On a related note, what happens if your device triggers an interrupt
    > between check_wakeup_irqs() and the actual suspend?  Since it is a
    > wakeup IRQ, wouldn't you want it to abort the suspend too?
    >

    check_wakeup_irqs is called after masking interrupts, so your existing
    platform specific check should catch it.

    --
    Arve Hjønnevåg
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-05-06 02:01    [W:0.023 / U:29.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site