lkml.org 
[lkml]   [2009]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/21] amd64_edac: assign DRAM chip select base and mask in a family-specific way
Em Tue, 5 May 2009 12:28:01 -0700 (PDT)
Doug Thompson <norsk5@yahoo.com> escreveu:

>
> --- On Mon, 5/4/09, Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>
> > From: Mauro Carvalho Chehab <mchehab@redhat.com>
> > Subject: Re: [PATCH 09/21] amd64_edac: assign DRAM chip select base and mask in a family-specific way
> > To: "Borislav Petkov" <borislav.petkov@amd.com>
> > Cc: akpm@linux-foundation.org, greg@kroah.com, mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com, dougthompson@xmission.com, linux-kernel@vger.kernel.org
> > Date: Monday, May 4, 2009, 3:59 PM
> > Borislav Petkov escreveu:
> > > +    for (cs = 0; cs <
> > CHIPSELECT_COUNT; cs++) {
> > > +        reg = K8_DCSB0
> > + (cs * 4);
> > > +        err =
> > pci_read_config_dword(pvt->dram_f2_ctl, reg,
> > > +       
> >            
> >     &pvt->dcsb0[cs]);
> > > +        if (err != 0)
> > > +       
> >     debugf0("%s() Reading K8_DCSB0[%d]
> > failed\n",
> > > +       
> >         __func__, cs);
> > > +
> > > +        debugf0(" 
> > DCSB0[%d]=0x%08x reg: F2x%x\n",
> > > +       
> >     cs, pvt->dcsb0[cs], reg);
> > >   
> >
> > Hmm... I suspect that there's a missing else before the
> > debugf0(). If you got an error while reading it, you
> > shouldn't be showing the results.
> > > +
> > > +        /* If DCT are
> > NOT ganged, then read in DCT1's base */
> > > +        if
> > (boot_cpu_data.x86 >= 0x10 &&
> > !dct_ganging_enabled(pvt)) {
> > > +       
> >     reg = F10_DCSB1 + (cs * 4);
> > > +       
> >     err =
> > pci_read_config_dword(pvt->dram_f2_ctl, reg,
> > > +       
> >            
> >        
> > &pvt->dcsb1[cs]);
> > > +       
> >     if (err != 0)
> > > +       
> >         debugf0("%s() Reading
> > F10_DCSB1[%d] failed\n",
> > > +       
> >            
> > __func__, cs);
> > > +       
> >     debugf0("  DCSB1[%d]=0x%08x reg:
> > F2x%x\n",
> > > +       
> >         cs, pvt->dcsb1[cs],
> > reg);
> > >   
> > The same issue here: if you got an error while reading it,
> > you shouldn't be showing the results.
> > Cheers,
> > Mauro.
> >
>
> An 'else' could be inserted, but it is only under DEBUG state for development purposes.

Yet, it seems worthy to have it.
>
> BACKGROUND: The error checking of the pci config space read was added during the time when the kernel couldn't read the extended 4k config space via the AMD IOConfig port access function (12 bits of offset) not via MMCONFIG.

As this is unlikely to happen, I would also replace the:
if (err != 0)

by:
if (unlikely(err))

in order to optimize the tests a little bit, avoiding the risk of cache flushes due to the branches.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-05-05 23:43    [W:0.040 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site