lkml.org 
[lkml]   [2009]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] integrity: use audit_log_string
From
Date
On Tue, 2009-05-05 at 13:13 -0400, Mimi Zohar wrote:
> Based on a request from Eric Paris to simplify parsing, replace
> audit_log_format statements containing "%s" with audit_log_string().
>
> Signed-off-by: Mimi Zohar <zohar@us.ibm.com>

As long as you don't mind that change from hash= to cause= I'm ok with
it too:

Acked-by: Eric Paris <eparis@redhat.com>

>
> Index: security-testing-2.6/security/integrity/ima/ima_audit.c
> ===================================================================
> --- security-testing-2.6.orig/security/integrity/ima/ima_audit.c
> +++ security-testing-2.6/security/integrity/ima/ima_audit.c
> @@ -54,19 +54,10 @@ void integrity_audit_msg(int audit_msgno
> audit_get_loginuid(current),
> audit_get_sessionid(current));
> audit_log_task_context(ab);
> - switch (audit_msgno) {
> - case AUDIT_INTEGRITY_DATA:
> - case AUDIT_INTEGRITY_METADATA:
> - case AUDIT_INTEGRITY_PCR:
> - case AUDIT_INTEGRITY_STATUS:
> - audit_log_format(ab, " op=%s cause=%s", op, cause);
> - break;
> - case AUDIT_INTEGRITY_HASH:
> - audit_log_format(ab, " op=%s hash=%s", op, cause);
> - break;
> - default:
> - audit_log_format(ab, " op=%s", op);
> - }
> + audit_log_format(ab, " op=");
> + audit_log_string(ab, op);
> + audit_log_format(ab, " cause=");
> + audit_log_string(ab, cause);
> audit_log_format(ab, " comm=");
> audit_log_untrustedstring(ab, current->comm);
> if (fname) {
>
>



\
 
 \ /
  Last update: 2009-05-05 20:03    [W:0.029 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site