lkml.org 
[lkml]   [2009]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] removes unused variable from kernel/sysctl.h
On Thu, 16 Apr 2009, Sukanto Ghosh wrote:

> This patch removes the unused variable 'val' from the
> __do_proc_dointvec() function
> in kernel/sysctl.h. The integer has been declared and used as 'val =
> -val' and there is
> no reference to it anywhere.
> Although I am this doesn't affects the kernel binary because gcc
> removes it, still it
> might be confusing for people reading the code.
>
>
> Signed-off-by: Sukanto Ghosh <sukanto.cse.iitb@gmail.com>
>
> ----
>
> --- linux-2.6.29.1/kernel/sysctl.c.orig 2009-04-16 19:57:21.000000000 +0530
> +++ linux-2.6.29.1/kernel/sysctl.c 2009-04-16 19:58:26.000000000 +0530
> @@ -2198,7 +2198,7 @@ static int __do_proc_dointvec(void *tbl_
> void *data)
> {
> #define TMPBUFLEN 21
> - int *i, vleft, first=1, neg, val;
> + int *i, vleft, first=1, neg;
> unsigned long lval;
> size_t left, len;
>
> @@ -2251,8 +2251,6 @@ static int __do_proc_dointvec(void *tbl_
> len = p-buf;
> if ((len < left) && *p && !isspace(*p))
> break;
> - if (neg)
> - val = -val;
> s += len;
> left -= len;

This doesn't seem to be picked up by anyone, CCing akpm.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2009-05-05 15:13    [W:0.050 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site