Messages in this thread | | | Date | Mon, 4 May 2009 07:53:48 -0700 | From | Greg KH <> | Subject | Re: [PATCH] usb: use memdup_user() |
| |
On Mon, May 04, 2009 at 10:41:51AM +0300, Pekka Enberg wrote: > Hi! > > On Sunday 03 May 2009, Oliver Neukum wrote: > >> No. To make it plain. To me any use of memdup_user() in USB code > >> is a bad idea. I don't want to have to think about a new primitive. > > On Mon, May 4, 2009 at 10:02 AM, David Brownell <david-b@pacbell.net> wrote: > > Unless it's incorrect to use that, I have to say that it > > makes more sense to use that utility than recreate it by > > open-coding... > > Yup, and I don't really see how anyone can avoid "thinking about a new > primitive" anyway. We have it in the kernel now and surely it will > appear under drivers/usb/ sooner or later...
Well, how about passing the GPF flags down to memdup_user() so that we can use it in the usb subsystem, and Oliver's complaint will be resolve?
thanks,
greg k-h
| |