Messages in this thread |  | | Date | Sun, 31 May 2009 17:31:44 +0100 | | From | Alan Cox <> | | Subject | Re: [PATCH] coredump: Retry writes where appropriate |
| |
O> Perhaps removing the "|| r == -EINTR" part would make both of you > happy? He gets the reliability on pipes, you keep the interrupt on > signals.
How does that improve things.
There is a second problem anyway. Suppose something is causing a continual stream of signal events - what guarantees it makes progress ?
The only source of signals during a dump should be external ones. Far better would be to set some kind of defined signal mask during the dump (say SIGPIPE, SIGINT, SIGQUIT) ? I agree with Paul's patch in the sense we don't want spurious SIGIO events or similar spoiling a dump.
Alan
|  |