Messages in this thread | | | Subject | Re: [PATCH 4/8] kernel:lockdep:implement find_usage_*wards by BFS | From | Daniel Walker <> | Date | Sun, 31 May 2009 08:14:21 -0700 |
| |
On Sun, 2009-05-31 at 22:49 +0800, tom.leiming@gmail.com wrote: > -static inline int __bfs_forward(struct lock_list *src_entry, > +static inline int __bfs_forwards(struct lock_list *src_entry,
Your patchset seems a bit young still .. For instance, adding an "s" in the above line, that's just flux that really shouldn't be there.. I was reviewing your patches but I stopped because it just looks like you need to organize them better. I wonder for one, if they bisect or if they pass checkpatch .. Your code also seems to have a lot of other little cleanup type issues..
Daniel
| |