Messages in this thread | | | Date | Sun, 31 May 2009 16:52:08 +0200 | From | Jiri Slaby <> | Subject | broken ide-tape |
| |
Hi,
ide-tape is broken since commit 346331f82823682fb5c2df6e827db25d95cc2e92 (ide-tape: remove atomic test/set macros for packet commands) from Apr 18 2008.
The commit introduced flags which are defined as (1 << nr) and uses them in {clear,set,test}_bit. And hence it must oops on each do_request.
Is it worth fixing (something like ilog2 added to each bit operation) or is a complete removal of the driver better "fix"?
| |