lkml.org 
[lkml]   [2009]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectbroken ide-tape
Hi,

ide-tape is broken since commit 346331f82823682fb5c2df6e827db25d95cc2e92
(ide-tape: remove atomic test/set macros for packet commands)
from Apr 18 2008.

The commit introduced flags which are defined as (1 << nr) and uses them
in {clear,set,test}_bit. And hence it must oops on each do_request.

Is it worth fixing (something like ilog2 added to each bit operation) or
is a complete removal of the driver better "fix"?


\
 
 \ /
  Last update: 2009-05-31 16:55    [W:0.046 / U:1.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site