Messages in this thread |  | | Date | Mon, 1 Jun 2009 08:14:00 +0800 | | Subject | Re: [PATCH 4/8] kernel:lockdep:implement find_usage_*wards by BFS | | From | Ming Lei <> |
| |
2009/5/31 Daniel Walker <dwalker@fifo99.com>: > On Sun, 2009-05-31 at 22:49 +0800, tom.leiming@gmail.com wrote: >> -static inline int __bfs_forward(struct lock_list *src_entry, >> +static inline int __bfs_forwards(struct lock_list *src_entry, > > Your patchset seems a bit young still .. For instance, adding an "s" in > the above line, that's just flux that really shouldn't be there.. I was > reviewing your patches but I stopped because it just looks like you need > to organize them better. I wonder for one, if they bisect or if they > pass checkpatch .. Your code also seems to have a lot of other little
Only No 3. patch has a checkpatch error, so we can continue to review them now, can't we?
> cleanup type issues.. > > Daniel > >
-- Lei Ming
|  |