lkml.org 
[lkml]   [2009]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] TXx9: Add TX4939 RNG support
From
Date
On Mon, 2009-06-01 at 02:23 +0900, Atsushi Nemoto wrote:
> On Sun, 31 May 2009 12:01:29 -0500, Matt Mackall <mpm@selenic.com> wrote:
> > > > Not clear to me how this works when this is a module?
> > >
> > > This patch add a registration of a platform device for RNG to vmlinux.
> > > And the other patch add a driver module for the RNG. This strategy is
> > > fairly common for SoCs or embedded platforms.
> >
> > If your driver is built as a module (which your patch allows), the above
> > won't work, right?
>
> No, the rng driver can be used regardless of module or built-in, as
> like as other platform drivers. Any special issue for hw_rng?

I found the source of my confusion: you've given the init function in
both files exactly the same name. So when I saw .._init at the bottom of
the second patch, I assumed it was referring to the possibly not loaded
driver's init code.

--
http://selenic.com : development and support for Mercurial and Linux




\
 
 \ /
  Last update: 2009-05-31 19:35    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog