lkml.org 
[lkml]   [2009]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC V2 PATCH]debugfs:Fix terminology inconsistency of dir name to mount debugfs filesystem.

    On Sat, 30 May 2009, GeunSik Lim wrote:
    > > Here's the function I use:
    > >
    > > #define _STR(x) x
    > > #define STR(x) _STR(x)
    > > #define MAX_PATH 256
    > >
    > > const char *find_debugfs(void)
    > > {
    > >        static char debugfs[MAX_PATH+1];
    > >        static int debugfs_found;
    > >        char type[100];
    > >        FILE *fp;
    > >
    > >        if (debugfs_found)
    > >                return debugfs;
    > >
    > >
    > >        if ((fp = fopen("/proc/mounts","r")) == NULL) {
    > >                perror("/proc/mounts");
    > >                return NULL;
    > >        }
    > >
    > >        while (fscanf(fp, "%*s %"
    > >                      STR(MAX_PATH)
    > >                      "s %99s %*s %*d %*d\n",
    > >                      debugfs, type) == 2) {
    > >                if (strcmp(type, "debugfs") == 0)
    > >                        break;
    > >        }
    > >        fclose(fp);
    > >
    > >        if (strcmp(type, "debugfs") != 0) {
    > >                fprintf(stderr, "debugfs not mounted");
    > >                return NULL;
    > >        }
    > >
    > >        debugfs_found = 1;
    > >
    > >        return debugfs;
    > > }
    > >
    > > This might be a good idea to show it. This is the most robust since it
    > > does not hard code the debugfs directory.
    > Yes, I think so. I have one opinion in the above find_debugfs() function.
    > Default directory is "/sys/kernel/debug/tracing" in ftrace.txt file
    > as you mentioned.
    > I will append below code for "***/tracing/" directory name.
    >
    > int size;
    > [...]
    > size = MAX_PATH - strlen(debugfs);
    > strncat(debugfs, "/tracing/", size);
    > return debugfs;

    Heh, I usually have another function to add the /tracing part. But sure,
    we could do that too.

    -- Steve
    \
     
     \ /
      Last update: 2009-05-30 15:39    [W:7.398 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site