Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 3/4] PM/Hibernate: Use memory allocations to free memory (rev. 2) | Date | Sun, 3 May 2009 18:15:32 +0200 |
| |
On Sunday 03 May 2009, Linus Torvalds wrote: > > On Sun, 3 May 2009, Rafael J. Wysocki wrote: > > > > Remove the shrinking of memory from the suspend-to-RAM code, where it is > > not really necessary. > > Hmm. Shouldn't we do this _regardless_? > > IOW, shouldn't this be a totally separate patch? It seems to be left-over > from when we shared the same code-paths, and before the split of the STR > and hibernate code? > > IOW, shouldn't the very _first_ patch just be this part? That code doesn't > make any sense anyway (that FREE_PAGE_NUMBER really _is_ totally > arbitrary). > > This part seems to be totally independent of all the other parts in your > patch-series. No?
I'm removing this along with shrink_all_memory() which it depends on, but I can put that into a separate patch if you prefer.
Thanks, Rafael
| |