Messages in this thread | | | Date | Sun, 3 May 2009 23:57:09 +0200 | From | Pavel Machek <> | Subject | Re: in_suspend and __nosave |
| |
Hi!
> While unifying vmlinux.lds for x86 I stumbled > over the .data.nosave section. > > Searching a bit I found only a single user: > > swsusp.c:int in_suspend __nosavedata = 0; > > Do we really needs all this complexity for this single integer? > We have this section defined in several arch lds files.
Well, original idea was that drivers may need some memory that's not affected by hibernation/restore....
> It also occur to me that only: x86, powerpc, and sh > implement pfn_is_nosave() which I think is the only > place where we decide if we want to save a page or not. > > But we define the .data.nosave section in following > architectures: > arm, m32r, mips, mn10300, parisc, s390 in addition > to the above archs that define pfn_is_nosave(). > Is this something to be cleaned up?
I guess people were just too happy with cut&paste. Ouch and someone was working on arm hibernation, iIRC.
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |