Messages in this thread | | | Date | Fri, 29 May 2009 20:50:28 -0700 | From | Andrew Morton <> | Subject | Re: IFF_LOWER_UP does not fit in ifr_flags |
| |
On Thu, 28 May 2009 14:59:05 +0200 "Fredrik Arnerup" <fredrik.arnerup@edgeware.tv> wrote:
> Documentation/networking/operstates.txt (and netdevice(7)) claims that > the flags IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO can be read from user space > using ioctl() with SIOCGIFFLAGS. Looking in include/linux/if.h however, > the flags are returned in a struct ifreq in the field ifr_flags which > is declared as a short, while the flags are defined as: > > #define IFF_LOWER_UP 0x10000 /* driver signals L1 up */ > #define IFF_DORMANT 0x20000 /* driver signals dormant */ > #define IFF_ECHO 0x40000 /* echo sent packets */ > > Those aren't shorts, are they? In net/core/dev.c dev_get_flags() returns > an unsigned which is assigned to ifr_flags directly. > > Looked at linux/kernel/git/stable/linux-2.6.29.y.git. > CC me please. >
(cc netdev)
| |