lkml.org 
[lkml]   [2009]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c
Andi Kleen wrote:
>> x86, mce: trivial clean up for mce_intel_64.c
>>
>> Fix for:
>>
>> WARNING: space prohibited between function name and open parenthesis '('
>> + for_each_online_cpu (cpu) {
>
> Sorry but that's just a bogus change. That's a loop and we always
> put spaces between the loop keyword and its condition.
>
> Just because checkpatch.pl is too dumb to understand that is no
> reason to make the code worse like that.
>

Look at EVERY OTHER for_each_online_cpu in the kernel.

-hpa



\
 
 \ /
  Last update: 2009-05-29 22:23    [W:0.030 / U:27.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site