| From | (Eric W. Biederman) | Date | Fri, 29 May 2009 13:18:35 -0700 | Subject | [PATCH 0/26] sysfs cleanups v3. |
| |
Here is the third respin of my sysfs patches.
Tejun had a good point I was doing to much when I touched __sysfs_read_dir. So that work has been split into 3 patches.
This made a good excuse for me to review the if (!dir_sd) check and be certain it was not needed. I have not found any actual problems so the resulting code is the same as the last patchset.
Now the change to delete each dirent in sysfs_read_dir is it's own separate patch so Tejun can happily beat me up on just that one idea. I honestly can't see how holding sysfs_mutex over the entire directory deletion helps anything.
The net change is less buggy than the current sysfs and a fair bit simpler.
git-diff-tree --stat v2.6.30-rc5..HEAD drivers/base/core.c | 21 +-- fs/namei.c | 22 -- fs/sysfs/dir.c | 596 ++++++++++++++++--------------------------------- fs/sysfs/file.c | 47 +--- fs/sysfs/inode.c | 154 ++++++++------ fs/sysfs/mount.c | 20 +- fs/sysfs/symlink.c | 93 +++++---- fs/sysfs/sysfs.h | 28 +-- include/linux/namei.h | 1 - include/linux/sysfs.h | 9 + 10 files changed, 383 insertions(+), 608 deletions(-)
Eric
|