Messages in this thread Patch in this message | | | Date | Fri, 29 May 2009 18:37:02 +0300 | From | Artem Bityutskiy <> | Subject | Re: [PATCH 0/11] Per-bdi writeback flusher threads v9 |
| |
Peter Zijlstra wrote: > On Thu, 2009-05-28 at 17:19 +0300, Artem Bityutskiy wrote: >> Artem Bityutskiy wrote: >>> question is - should it? 'bdi_register()' a block device, >>> but we do not have one. >> Sorry, wanted to say: 'bdi_register()' registers a block >> device. > > BDI stands for backing device info and is not related to block devices > other than that block devices can also be (ok, always are) backing > devices. > > If you want to do writeback, you need a backing device to write to. The > BDI is the device abstraction for writeback.
I see, thanks. The below UBIFS patch fixes the issue. I'll push it to ubifs-2.6.git tree, unless there are objections.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Subject: [PATCH] UBIFS: do not forget to register BDI device
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> --- fs/ubifs/super.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 2349e2c..d1ac967 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -1929,6 +1929,9 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) err = bdi_init(&c->bdi); if (err) goto out_close; + err = bdi_register(&c->bdi, NULL, "ubifs"); + if (err) + goto out_close; err = ubifs_parse_options(c, data, 0); if (err) -- 1.6.0.6 -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |