Messages in this thread Patch in this message | | | Date | Fri, 29 May 2009 11:33:19 +0800 | From | Ming Lei <> | Subject | Re: [PATCH] driver core : fix request_firmware_nowait |
| |
On Thu, 28 May 2009 18:43:41 -0700 Greg KH <greg@kroah.com> wrote: > > Anyway, I suggest just fixing the documentation, it's easier :)
Ok, it is the patch which fixes the documentation. Thanks.
From 32a1fe6013ed796d397417cc60d5e9a2aa66d74a Mon Sep 17 00:00:00 2001 From: Ming Lei <tom.leiming@gmail.com> Date: Fri, 29 May 2009 11:23:04 +0800 Subject: [PATCH] driver core: fix documentation of request_firmware_nowait
request_firmware_nowait declares it can be called in non-sleep contexts, but kthead_run called by request_firmware_nowait may sleep. So fix its documentation and comment to make callers clear about it.
Signed-off-by: Ming Lei <tom.leiming@gmail.com> --- Documentation/firmware_class/README | 3 ++- drivers/base/firmware_class.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/firmware_class/README b/Documentation/firmware_class/README index c3480aa..3a37ad3 100644 --- a/Documentation/firmware_class/README +++ b/Documentation/firmware_class/README @@ -77,7 +77,8 @@ seconds for the whole load operation. - request_firmware_nowait() is also provided for convenience in - non-user contexts. + user contexts to request firmware asynchronously, but can't be called + in atomic contexts. about in-kernel persistence: diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 2d296b7..2427702 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -617,8 +617,9 @@ request_firmware_work_func(void *arg) * @cont: function will be called asynchronously when the firmware * request is over. * - * Asynchronous variant of request_firmware() for contexts where - * it is not possible to sleep. + * Asynchronous variant of request_firmware() for user contexts where + * it is not possible to sleep for long time. It can't be called + * in atomic contexts. **/ int request_firmware_nowait( -- 1.6.0.GIT
-- Lei Ming
| |