lkml.org 
[lkml]   [2009]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Dynamic Tick: Prevent clocksource wrapping during idle
On Thu, 28 May 2009, Jon Hunter wrote:
> /**
> + * clocksource_max_deferment - Returns max time the clocksource can be
> deferred
> + * @cs: Pointer to clocksource
> + *
> + */
> +static inline s64 clocksource_max_deferment(struct clocksource *cs)

Please make this a real function. There is no reason to stick this
into a header file. The only user is clocksource.c anyway, so please
put it there as a static function and let the compiler decide what
to do with it.

Otherwise, I'm happy with it.

Thanks,

tglx


\
 
 \ /
  Last update: 2009-05-28 22:39    [W:0.112 / U:2.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site