lkml.org 
[lkml]   [2009]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] tracing/stat: remember to free root node
    Date
    From: Li Zefan <lizf@cn.fujitsu.com>

    When closing a trace_stat file, we destroy the rbtree constructed during
    file open, but there is memory leak that the root node is not freed.

    [ Impact: fix memory leak when closing a trace_stat file ]

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    ---
    kernel/trace/trace_stat.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c
    index 8b7420a..a80d947 100644
    --- a/kernel/trace/trace_stat.c
    +++ b/kernel/trace/trace_stat.c
    @@ -60,8 +60,8 @@ static struct rb_node *release_next(struct rb_node *node)
    return node->rb_right;
    else {
    if (!parent)
    - return NULL;
    - if (parent->rb_left == node)
    + ;
    + else if (parent->rb_left == node)
    parent->rb_left = NULL;
    else
    parent->rb_right = NULL;
    --
    1.6.2.3


    \
     
     \ /
      Last update: 2009-05-28 18:47    [W:0.020 / U:58.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site