lkml.org 
[lkml]   [2009]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] tracing/stat: change dummpy_cmp() to return -1
    Date
    From: Li Zefan <lizf@cn.fujitsu.com>

    Currently the output of trace_stat/workqueues is totally reversed:

    # cat /debug/tracing/trace_stat/workqueues
    ...
    1 17 17 210 37 `-blk_unplug_work+0x0/0x57
    1 3779 3779 181 11 |-cfq_kick_queue+0x0/0x2f
    1 3796 3796 kblockd/1:120
    ...

    The correct output should be:

    1 3796 3796 kblockd/1:120
    1 3779 3779 181 11 |-cfq_kick_queue+0x0/0x2f
    1 17 17 210 37 `-blk_unplug_work+0x0/0x57

    It's caused by "tracing/stat: replace linked list by an rbtree for
    sorting"
    (53059c9b67a62a3dc8c80204d3da42b9267ea5a0).

    dummpy_cmp() should return -1, so rb_node will always be inserted as
    right-most node in the rbtree, thus we sort the output in ascending
    order.

    [ Impact: fix the output of trace_stat/workqueues ]

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    ---
    kernel/trace/trace_stat.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c
    index 2e849b5..8b7420a 100644
    --- a/kernel/trace/trace_stat.c
    +++ b/kernel/trace/trace_stat.c
    @@ -127,7 +127,7 @@ insert_stat(struct rb_root *root, struct stat_node *data, cmp_stat_t cmp)
    */
    static int dummy_cmp(void *p1, void *p2)
    {
    - return 1;
    + return -1;
    }

    /*
    --
    1.6.2.3


    \
     
     \ /
      Last update: 2009-05-28 18:45    [W:0.023 / U:32.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site