lkml.org 
[lkml]   [2009]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] freezer: cleanup printk call sequences
Date
Correct and ease printk() interaction among freeze_processes()
and try_to_freeze_tasks().

Move printk("done") in thaw_processes() before schedule() to
prevent implicit interferences from it.

Signed-off-by: Michael Roth <mroth@nessie.de>
---
kernel/power/process.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/kernel/power/process.c b/kernel/power/process.c
index ca63401..f6bd3de 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -92,7 +92,7 @@ static int try_to_freeze_tasks(bool sig_only)
} while_each_thread(g, p);
read_unlock(&tasklist_lock);
} else {
- printk("(elapsed %d.%02d seconds) ", elapsed_csecs / 100,
+ printk("(elapsed %d.%02d seconds) done.\n", elapsed_csecs / 100,
elapsed_csecs % 100);
}

@@ -110,16 +110,12 @@ int freeze_processes(void)
error = try_to_freeze_tasks(true);
if (error)
goto Exit;
- printk("done.\n");

printk("Freezing remaining freezable tasks ... ");
error = try_to_freeze_tasks(false);
- if (error)
- goto Exit;
- printk("done.");
+
Exit:
BUG_ON(in_atomic());
- printk("\n");
return error;
}

@@ -148,7 +144,7 @@ void thaw_processes(void)
printk("Restarting tasks ... ");
thaw_tasks(true);
thaw_tasks(false);
- schedule();
printk("done.\n");
+ schedule();
}

--
1.6.0.6


\
 
 \ /
  Last update: 2009-05-28 18:15    [W:0.030 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site