lkml.org 
[lkml]   [2009]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/12] Per-bdi writeback flusher threads v7
On Wed, May 27 2009, Andrew Morton wrote:
> On Wed, 27 May 2009 17:05:47 +0200
> Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > I ran testing with artificial
> > bdi_work allocation failures to verify the oom path
>
> I bet you didn't use lib/fault-inject.c :(

I didn't, it was a 2-second hack to add a

static int i;

if (!(i++ % 4))
return NULL;

so I didn't look further...

> For tricky pieces of core kernel like this, there's a good case for
> including and permanently maintaining fault injection testing
> capabilities.

I agree.

--
Jens Axboe



\
 
 \ /
  Last update: 2009-05-28 12:23    [W:0.065 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site