Messages in this thread | | | Date | Wed, 27 May 2009 09:24:45 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 19/31] x86: MCE: Default to panic timeout for machine checks v2 |
| |
On Wed, May 27, 2009 at 01:31:07PM +0900, Hidetoshi Seto wrote: > I suppose the original intention is overwrite the panic_timeout 0 to 30.
Yes.
> > @@ -1100,6 +1105,8 @@ static void mce_cpu_quirks(struct cpuinfo_x86 *c) > > } > > if (monarch_timeout < 0) > > monarch_timeout = 0; > > + if (mce_bootlog != 0) > > + mce_panic_timeout = 30; > > } > > > > static void __cpuinit mce_ancient_init(struct cpuinfo_x86 *c) > > It seems it doesn't work.
Okay fair point. I applied your earlier review suggestion literally yes that was not correct. I changed it in my patchkit to handle the 0 case too.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |