Messages in this thread | | | Date | Thu, 28 May 2009 01:12:48 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] ptrace: do_notify_parent_cldstop: fix the wrong ->nsproxy usage |
| |
On 05/27, Roland McGrath wrote: > > > Actually, ptrace_signal() is fine wrt pid_ns. task_pid_vnr(current->parent) > > returns 0 if the tracer is not seen from the tracee's namespace, this is > > correct. So, afaics only ptrace_notify() needs the (low priority) fix. > > Oh, both are correct. Sorry. These are signals received by tracee, which > is current, so task_pid_vnr() dtrt.
No, task_pid_vnr(current) in ptrace_notify() is not right. If the tracer does PTRACE_GETSIGINFO it gets the wrong .si_pid.
Oleg.
| |