lkml.org 
[lkml]   [2009]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ftrace: Don't convert function's local variable name in macro
On Thu, May 28, 2009 at 01:14:35AM +0200, Ingo Molnar wrote:
>
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > On Wed, May 27, 2009 at 09:36:02PM +0800, Zhaolei wrote:
> > > "call" is a argument of macro, but it is also used as a local variable name of
> > > function in macro.
> > > We should keep this local variable name static although it haven't cause
> > > problem now.
> > >
> > > [ Impact: cleanup, no functionality changed ]
> >
> >
> > I'm applying it.
> >
> > Note, I'm also changing the impact line. This is more than a
> > cleanup, it's a real fix to prevent from possible CPP side effects.
> >
> > So I'll put instead:
> >
> > [ Impact: prevent from accidental CPP substitution ]
>
> I suspect it should be something like:
>
> [ Impact: robustify macro ]


Ok, I take this one!

Thanks.


> or so.
>
> Ingo



\
 
 \ /
  Last update: 2009-05-28 01:19    [W:0.024 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site