Messages in this thread | | | Date | Thu, 28 May 2009 01:14:35 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] ftrace: Don't convert function's local variable name in macro |
| |
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Wed, May 27, 2009 at 09:36:02PM +0800, Zhaolei wrote: > > "call" is a argument of macro, but it is also used as a local variable name of > > function in macro. > > We should keep this local variable name static although it haven't cause > > problem now. > > > > [ Impact: cleanup, no functionality changed ] > > > I'm applying it. > > Note, I'm also changing the impact line. This is more than a > cleanup, it's a real fix to prevent from possible CPP side effects. > > So I'll put instead: > > [ Impact: prevent from accidental CPP substitution ]
I suspect it should be something like:
[ Impact: robustify macro ]
or so.
Ingo
| |