Messages in this thread | | | Date | Wed, 27 May 2009 15:48:16 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] Time out for possible dead loops during queued invalidation wait |
| |
On Wed, 27 May 2009 15:40:35 -0700 "Yu, Fenghua" <fenghua.yu@intel.com> wrote:
> >> + WARN(1, "No space in invalidation queue.\n"); > >> + return -ENOSPC; > > > >ENOSPC means "your disk filled up". I think it makes no sense to use > >that error code in this context, even though it kinda sounds the same. > > > > Which error code is better? Is EAGAIN ok?
That depends on driver details - probably EIO would be suitable, dunno.
But all the callers of qi_submit_sync() seem to just drop the error code on the floor:
/* should never fail */ qi_submit_sync(&desc, iommu);
and may well cause a kernel crash as a result.
| |