lkml.org 
[lkml]   [2009]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Time out for possible dead loops during queued invalidation wait
On Wed, 27 May 2009 15:40:35 -0700
"Yu, Fenghua" <fenghua.yu@intel.com> wrote:

> >> + WARN(1, "No space in invalidation queue.\n");
> >> + return -ENOSPC;
> >
> >ENOSPC means "your disk filled up". I think it makes no sense to use
> >that error code in this context, even though it kinda sounds the same.
> >
>
> Which error code is better? Is EAGAIN ok?

That depends on driver details - probably EIO would be suitable, dunno.

But all the callers of qi_submit_sync() seem to just drop the error
code on the floor:

/* should never fail */
qi_submit_sync(&desc, iommu);

and may well cause a kernel crash as a result.


\
 
 \ /
  Last update: 2009-05-28 00:51    [W:0.131 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site