Messages in this thread | | | Subject | Re: [PATCH] firmware: Allocate firmware id dynamically | From | Marcel Holtmann <> | Date | Wed, 27 May 2009 08:19:46 +0200 |
| |
Hi Samuel,
> > Since the firmware loader is not maintained by anyone, I'm sending this one to > > you, for the next merge window: > > It's part of the driver-core directory, and handled by Greg. > > > The firmware loader has a statically allocated 30 bytes long string for the > > firmware id (a.k.a. the firmware file name). There is no reason why we couldnt > > allocate dynamically, and avoid having restrictions on the firmware names > > lengths. > > Looks good.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
> > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as > > some drivers rely on it. > > I think the 6 files should be converted, and FIRMWARE_NAME_MAX > removed, otherwise people will keep copying that crap around. > > drivers/pcmcia/ds.c > drivers/usb/atm/ueagle-atm.c > drivers/net/wireless/libertas/if_usb.c > drivers/net/wireless/libertas/if_spi.c > drivers/media/dvb/dvb-usb/dvb-usb.h > drivers/media/common/tuners/tuner-xc2028.c
I do agree with Kay here that we should just go ahead and fix these.
Regards
Marcel
| |