Messages in this thread | | | Date | Wed, 27 May 2009 15:05:08 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH 2/3] add inactive ratio calculation function of each zone V2 |
| |
On Tue, 26 May 2009 22:30:02 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 21 May 2009 09:23:21 +0900 Minchan Kim <minchan.kim@gmail.com> wrote: > > > Changelog since V1 > > o Change function name from calculate_zone_inactive_ratio to calculate_inactive_ratio > > - by Mel Gorman advise > > o Modify tab indent - by Mel Gorman advise > > The first two patches still had various trivial whitespace bustages. > You don't need Mel to find these things when we have the very nice > scripts/checkpatch.pl. Please incorporate that script into your patch > preparation tools
Oops. I thought I tried to do checkpatch.pl with my patches.
> > This patch devide setup_per_zone_inactive_ratio with > > per-zone inactive ratio calculaton. > > The above sentence appears to be the changelog for this patch but it > doesn't make a lot of sense. > > afaict the changelog should be: > > "factor the per-zone arithemetic inside > setup_per_zone_inactive_ratio()'s loop into a a separate function, > calculate_zone_inactive_ratio(). This function will be used in a later > patch". > > yes?
Exactly.
I will repost this with your improved changelog. Thanks. Andrew.
-- Kinds Regards Minchan Kim
| |