Messages in this thread | | | Subject | Re: [PATCH -tip] Documentation/connector/cn_test.c remove unused cn_test_want_notify() | From | Jaswinder Singh Rajput <> | Date | Wed, 27 May 2009 14:07:12 +0530 |
| |
Hello Andrew,
If you want, you can also apply this patch along with another Documentation patch.
And also add ACK from Evgeniy Polyakov <zbr@ioremap.net>
Thanks, -- JSR
On Wed, 2009-05-20 at 13:12 +0530, Jaswinder Singh Rajput wrote: > On Wed, 2009-05-20 at 11:22 +0400, Evgeniy Polyakov wrote: > > On Wed, May 20, 2009 at 11:04:53AM +0530, Jaswinder Singh Rajput (jaswinder@kernel.org) wrote: > > > > > > Currently cn_test_want_notify() is not having any user. > > > > Do not remove it, disable with ifdef if you want, it is an example > > of how to get notifications about new connector user registration. > > > > [PATCH -tip] Documentation/connector/cn_test.c comment unused cn_test_want_notify() > > Currently cn_test_want_notify() is not having any user. > > So adding ifdef and comment which tells to not remove it. > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > --- > Documentation/connector/cn_test.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/Documentation/connector/cn_test.c b/Documentation/connector/cn_test.c > index 6977c17..f688eba 100644 > --- a/Documentation/connector/cn_test.c > +++ b/Documentation/connector/cn_test.c > @@ -41,6 +41,12 @@ void cn_test_callback(void *data) > msg->seq, msg->ack, msg->len, (char *)msg->data); > } > > +/* > + * Do not remove this function even if no one is using it as > + * this is an example of how to get notifications about new > + * connector user registration > + */ > +#if 0 > static int cn_test_want_notify(void) > { > struct cn_ctl_msg *ctl; > @@ -117,6 +123,7 @@ nlmsg_failure: > kfree_skb(skb); > return -EINVAL; > } > +#endif > > static u32 cn_test_timer_counter; > static void cn_test_timer_func(unsigned long __data)
| |