lkml.org 
[lkml]   [2009]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/31] x86: MCE: Store record length into memory struct mce anchor
    Date
    From: Andi Kleen <ak@linux.intel.com>

    This makes it easier for tools who want to extract the mcelog out of
    crash images or memory dumps to adapt to changing struct mce size.
    The length field replaces padding, so it's fully compatible.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    ---
    arch/x86/include/asm/mce.h | 2 +-
    arch/x86/kernel/cpu/mcheck/mce.c | 5 +++--
    2 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
    index 1ff437f..6f45a87 100644
    --- a/arch/x86/include/asm/mce.h
    +++ b/arch/x86/include/asm/mce.h
    @@ -59,7 +59,7 @@ struct mce_log {
    unsigned len; /* = MCE_LOG_LEN */
    unsigned next;
    unsigned flags;
    - unsigned pad0;
    + unsigned recordlen; /* length of struct mce */
    struct mce entry[MCE_LOG_LEN];
    };

    diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
    index d87f46f..bf9bd6f 100644
    --- a/arch/x86/kernel/cpu/mcheck/mce.c
    +++ b/arch/x86/kernel/cpu/mcheck/mce.c
    @@ -121,8 +121,9 @@ EXPORT_PER_CPU_SYMBOL_GPL(injectm);
    */

    static struct mce_log mcelog = {
    - MCE_LOG_SIGNATURE,
    - MCE_LOG_LEN,
    + .signature = MCE_LOG_SIGNATURE,
    + .len = MCE_LOG_LEN,
    + .recordlen = sizeof(struct mce),
    };

    void mce_log(struct mce *mce)
    --
    1.6.0.2


    \
     
     \ /
      Last update: 2009-05-27 02:05    [W:0.027 / U:29.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site