lkml.org 
[lkml]   [2009]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6.27.24] Kernel coredump to a pipe is failing
On Wed, 27 May 2009 01:14:28 +0200
Andi Kleen <andi@firstfloor.org> wrote:

> On Tue, May 26, 2009 at 04:00:17PM -0700, Andrew Morton wrote:
> > dump_write() doesn't seem right, either. If ->write() returns, say,
> > 100 then the dump should keep on going. At present it treats this
> > return as an error.
>
> I think that's correct actually. Short write typically means serious
> issue like disk full or broken pipe, so stopping is good.

But we shouldn't assume that. It could be that the ->write
implementation is perfectly able to absorb the remaining data.

We should only error out of the write() returned zero or -EFOO.
The current code is simply buggy, but got lucky.



\
 
 \ /
  Last update: 2009-05-27 01:31    [W:0.133 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site