lkml.org 
[lkml]   [2009]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: USB/DVB - Old Technotrend TT-connect S-2400 regression tracked down
David wrote:
> Alan Stern wrote:
>
>> Okay, here's a patch for you to try. It refreshes the toggle setting
>> in a linked but otherwise idle QH when a new URB is queued.
>>
>> Alan Stern
>>
>>
>> Index: usb-2.6/drivers/usb/host/ehci-q.c
>> ===================================================================
>> --- usb-2.6.orig/drivers/usb/host/ehci-q.c
>> +++ usb-2.6/drivers/usb/host/ehci-q.c
>> @@ -88,7 +88,7 @@ static inline void
>> qh_update (struct ehci_hcd *ehci, struct ehci_qh *qh, struct ehci_qtd *qtd)
>> {
>> /* writes to an active overlay are unsafe */
>> - BUG_ON(qh->qh_state != QH_STATE_IDLE);
>> + BUG_ON(qh->qh_state != QH_STATE_IDLE && !list_empty(&qh->qtd_list));
>>
>> qh->hw_qtd_next = QTD_NEXT(ehci, qtd->qtd_dma);
>> qh->hw_alt_next = EHCI_LIST_END(ehci);
>> @@ -971,7 +971,13 @@ static struct ehci_qh *qh_append_tds (
>> /* can't sleep here, we have ehci->lock... */
>> qh = qh_make (ehci, urb, GFP_ATOMIC);
>> *ptr = qh;
>> + } else if (list_empty(&qh->qtd_list)) {
>> + /* There might have been a Clear-Halt while the QH
>> + * was linked but empty.
>> + */
>> + qh_refresh(ehci, qh);
>> }
>> +
>> if (likely (qh != NULL)) {
>> struct ehci_qtd *qtd;
>>
>>
>>
>>
> No luck I'm afraid (although there now appear to be 2 timeouts, not
> one). I'm going to follow up on the laptop and get a USB log.
>
USB log post-patch attached. Thanks for all the effort so far!

David
[unhandled content-type:application/x-bzip]
\
 
 \ /
  Last update: 2009-05-25 20:49    [W:0.094 / U:0.028 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site