lkml.org 
[lkml]   [2009]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend4 2/3] itimers: fix periodic tics precision
On Mon, 25 May 2009 14:32:14 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 25 May 2009, Stanislaw Gruszka wrote:
> > @@ -904,6 +905,7 @@ void __init time_init(void)
> > tb_ticks_per_usec = ppc_tb_freq / 1000000;
> > tb_to_us = mulhwu_scale_factor(ppc_tb_freq, 1000000);
> > calc_cputime_factors();
> > + cputime_one = jiffies_to_cputime(1);
>
> 1) The variable name is misleading.

What about cputime_one_jiffy ?

> 2) The patch breaks all powerpc platforms which have
> CONFIG_VIRT_CPU_ACCOUNTING=n and ia64 with
> CONFIG_VIRT_CPU_ACCOUNTING=y

Stupid me, in asm-generic/cputime.h should be
#define cputime_one jiffies_to_cputime(1)

Thanks
Stanislaw


\
 
 \ /
  Last update: 2009-05-25 15:01    [from the cache]
©2003-2011 Jasper Spaans