Messages in this thread | | | Date | Mon, 25 May 2009 14:12:25 +0200 | From | Nick Piggin <> | Subject | Re: [GIT PULL] scheduler fixes |
| |
On Mon, May 25, 2009 at 03:04:20PM +0300, Pekka Enberg wrote: > > On Mon, May 25, 2009 at 02:37:59PM +0300, Pekka Enberg wrote: > > > On Mon, May 25, 2009 at 2:25 PM, Nick Piggin <npiggin@suse.de> wrote: > > > > The bootmem allocations of course are required because some hashes may > > > > need to be larger than MAX_ORDER without using vmalloc. > > > > > > > > kmem_cache_init (and mem_init, partially) sets up the kernel memory > > > > allocators... > > > > > > Which comment are you talking about? The "setup kernel memory > > > allocators" one? Yeah, I should probably move it couple of lines down. > > On Mon, 25 May 2009, Nick Piggin wrote: > > Yes, just that one. > > And oh, we probably want to do this too while at it. Nick? > > >From b211497261670ff6f9af6b8b0fab429e848ccc87 Mon Sep 17 00:00:00 2001 > From: Pekka Enberg <penberg@cs.helsinki.fi> > Date: Mon, 25 May 2009 15:01:35 +0300 > Subject: [PATCH] vmalloc: use kzalloc() instead of alloc_bootmem() > > We can call vmalloc_init() after kmem_cache_init() and use kzalloc() instead of > the bootmem allocator when initializing vmalloc data structures. > > Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> > --- > init/main.c | 2 +- > mm/vmalloc.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/init/main.c b/init/main.c > index fb0e004..766194c 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -585,13 +585,13 @@ asmlinkage void __init start_kernel(void) > __stop___param - __start___param, > &unknown_bootoption); > pidhash_init(); > - vmalloc_init(); > vfs_caches_init_early(); > /* > * Set up kernel memory allocators > */ > mem_init(); > kmem_cache_init(); > + vmalloc_init();
vmalloc won't work fully without slab and page allocators anyway, so this is conceptually a bugfix I think. Ack.
| |