lkml.org 
[lkml]   [2009]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories.
On Mon, May 25, 2009 at 09:53, Eric W. Biederman <ebiederm@xmission.com> wrote:
> ebiederm@xmission.com (Eric W. Biederman) writes:

> Currently I expect that those attributes that are not deleted may
> actually be bugs as well.  If a driver manually adds sysfs files after
> device_create/device_register the uevent will have already been sent
> and you can not safely use those attributes in when processing a hotplug
> event.

That's true, and would be good to fix. I guess we need to come up with
a way of maintaining binary attributes in the same way as "default"
attributes. Today they need to be created manually.

Maybe we can get your patch series in, with the version that removes
the files, but warns on existing directories, and work on fixing the
users, and possible remove the deletion of files when we fixed all the
current users?

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-05-25 12:57    [W:0.198 / U:1.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site