Messages in this thread | | | Date | Mon, 25 May 2009 12:49:08 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 03/13] scsi: unify allocation of scsi command and sense buffer |
| |
On Mon, May 25 2009, Christoph Hellwig wrote: > On Mon, May 25, 2009 at 01:33:42PM +0300, Boaz Harrosh wrote: > > 1. If we have a machine with few type of hosts active each with it's own > > cmnd_slab we end up with many more slabs then today. Even though at the > > end they all happen to be of the same size. (With the pool reserves it > > can get big also). > > Note that this should be optional. Device not having their own > per-command structure would continue using the global pools. Those > that have their own per-command structures already have their own pools > anyway.
The multiple pools of the same size "issue" can also easily be resolved by having SCSI provide a way to setup/destroy these pools. Then it can just reuse an existing pool, if it has the same size.
However, I doubt that this is really a real life issue that's worth worrying about.
-- Jens Axboe
| |