Messages in this thread | | | From | "Zhaolei" <> | Subject | Re: [PATCH v2 0/2] ftrace: Add task_comm support for trace_event | Date | Mon, 25 May 2009 16:59:26 +0800 |
| |
* From: "Ingo Molnar" <mingo@elte.hu> > > it still fails to build: > > kernel/built-in.o: In function `ftrace_event_enable_disable': > trace_events.c:(.text+0x4df08): undefined reference to `tracing_stop_cmdline_record' > trace_events.c:(.text+0x4df1f): undefined reference to `tracing_start_cmdline_record' > > config attached.
Hello, Ingo
Thanks for your report.
I found reason. It is because CONFIG_TRACING is on(But CONFIG_FTRACE is off), which compiles trace_events but leaves trace_sched_switch. (It is different with problem that I fixed in v1->v2, but... sorry......)
I have fixed it, I'll send v3 after following test: 1: CONFIG_TRACING on, CONFIG_FTRACE off 2: CONFIG_ENABLE_EVENT_TRACING on, CONFIG_ENABLE_CONTEXT_SWITCH_TRACER off 2: CONFIG_ENABLE_EVENT_TRACING on, CONFIG_ENABLE_CONTEXT_SWITCH_TRACER on
And RFC: IMHO, trace_sched_switch should not have relationship with trace_events, in other words, trace_events should run without trace_sched_switch linked.
Can we move codes for record cmdline out of trace_sched_switch.c and put them into new cmdline_record.c? Then, trace_functions.c and trace_events.c will only need cmdline_record.c.
Thanks Zhaolei
| |