Messages in this thread | | | Date | Sat, 23 May 2009 00:03:29 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH 2/2] firewire: core: add sysfs attribute for easier udev rules |
| |
Stefan Richter wrote: > + while (fw_csr_iterator_next(&ci, &key, &value)) { > + if (key != (CSR_UNIT | CSR_DIRECTORY)) > + continue; > + i += units_sprintf(&buf[i], ci.p + value - 1); > + if (i >= PAGE_SIZE - (8 + 1 + 8 + 1)) > + break; > + } > + up_read(&fw_device_rwsem); > + > + sprintf(&buf[i ? i - 1 : 0], "\n");
Rather: if (i) buf[i - 1] = '\n'; > + > + return i; > +} -- Stefan Richter -=====-==--= -=-= =-=== http://arcgraph.de/sr/
| |