lkml.org 
[lkml]   [2009]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/9] amd-iommu: drop pointless iommu-loop in msi setup code
    Date
    Impact: cleanup

    It is not necessary to loop again over all IOMMUs in this code. So drop
    the loop.

    Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    ---
    arch/x86/kernel/amd_iommu_init.c | 8 +-------
    1 files changed, 1 insertions(+), 7 deletions(-)

    diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
    index 74f4f1f..cc99f60 100644
    --- a/arch/x86/kernel/amd_iommu_init.c
    +++ b/arch/x86/kernel/amd_iommu_init.c
    @@ -826,13 +826,6 @@ out_free:
    static int __init iommu_setup_msi(struct amd_iommu *iommu)
    {
    int r;
    - struct amd_iommu *curr;
    -
    - for_each_iommu(curr) {
    - if (curr->dev == iommu->dev)
    - curr->int_enabled = true;
    - }
    -

    if (pci_enable_msi(iommu->dev))
    return 1;
    @@ -847,6 +840,7 @@ static int __init iommu_setup_msi(struct amd_iommu *iommu)
    return 1;
    }

    + iommu->int_enabled = true;
    iommu_feature_enable(iommu, CONTROL_EVT_INT_EN);

    return 0;
    --
    1.6.3.1



    \
     
     \ /
      Last update: 2009-05-22 14:21    [W:0.049 / U:2.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site