Messages in this thread Patch in this message | | | From | Alexey Dobriyan <> | Subject | [PATCH 09/38] netns 1/2: don't get/put old netns on CLONE_NEWNET | Date | Fri, 22 May 2009 08:55:03 +0400 |
| |
copy_net_ns() doesn't copy anything, it creates fresh netns, so get/put of old netns isn't needed.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Acked-by: Serge Hallyn <serue@us.ibm.com> --- net/core/net_namespace.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index e3bebd3..4488010 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -120,10 +120,8 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net) struct net *new_net = NULL; int err; - get_net(old_net); - if (!(flags & CLONE_NEWNET)) - return old_net; + return get_net(old_net); err = -ENOMEM; new_net = net_alloc(); @@ -142,7 +140,6 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net) if (err) goto out_free; out: - put_net(old_net); return new_net; out_free: -- 1.5.6.5
| |