| Date | Fri, 22 May 2009 17:00:51 +0800 | From | Amerigo Wang <> | Subject | Re: [PATCH 03/38] ipcns 1/4: remove useless get/put while CLONE_NEWIPC |
| |
On Fri, May 22, 2009 at 08:54:57AM +0400, Alexey Dobriyan wrote: >copy_ipcs() doesn't actually copy anything. If new ipcns is created, it's >created from scratch, in this case get/put on old ipcns isn't needed. > >Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> >Acked-by: Serge Hallyn <serue@us.ibm.com>
Looks good to me!
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
>--- > ipc/namespace.c | 6 +----- > 1 files changed, 1 insertions(+), 5 deletions(-) > >diff --git a/ipc/namespace.c b/ipc/namespace.c >index 4a5e752..a56fc59 100644 >--- a/ipc/namespace.c >+++ b/ipc/namespace.c >@@ -50,15 +50,11 @@ struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns) > { > struct ipc_namespace *new_ns; > >- BUG_ON(!ns); >- get_ipc_ns(ns); >- > if (!(flags & CLONE_NEWIPC)) >- return ns; >+ return get_ipc_ns(ns); > > new_ns = clone_ipc_ns(ns); > >- put_ipc_ns(ns); > return new_ns; > } > >-- >1.5.6.5 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/
|