lkml.org 
[lkml]   [2009]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] tracing: convert irq events to use __print_symbolic
> +#define softirq_name(sirq) { sirq, #sirq }
> +#define show_softirq_name(val) \
> + __print_symbolic(val, \
> + softirq_name(HI_SOFTIRQ), \
> + softirq_name(TIMER_SOFTIRQ), \
> + softirq_name(NET_TX_SOFTIRQ), \
> + softirq_name(NET_RX_SOFTIRQ), \
> + softirq_name(BLOCK_SOFTIRQ), \
> + softirq_name(TASKLET_SOFTIRQ), \
> + softirq_name(SCHED_SOFTIRQ), \
> + softirq_name(HRTIMER_SOFTIRQ), \
> + softirq_name(RCU_SOFTIRQ))
> +

The ending "_SOFTIRQ" is just redundant.

And it's you that removed "_SOFTIRQ" in the output of irq
trace events. ;)

==========
commit 899039e8746bb9a09b6487ddb8ab2275ce9d0256
Author: Steven Rostedt <srostedt@redhat.com>
Date: Fri Mar 13 00:43:33 2009 -0400
softirq: no need to have SOFTIRQ in softirq name

Impact: clean up

It is redundant to have 'SOFTIRQ' in the softirq names.
==========
How about:

#define softirq_name(sirq) { sirq ## _SOFTIRQ, #sirq }
#define show_softirq_name(val) \
__print_symbolic(val, \
softirq_name(HI), \
or:

#define softirq_name(sirq) { sirq, softirq_to_name[sirq] }


\
 
 \ /
  Last update: 2009-05-21 07:39    [from the cache]
©2003-2011 Jasper Spaans